Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgParser rewrite #3946

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

ArgParser rewrite #3946

wants to merge 3 commits into from

Conversation

YoshiRulz
Copy link
Member

I'd still like to improve the documentation further, but this is functional already. If you have scripts for e.g. encoding please test them.

@Morilli
Copy link
Collaborator

Morilli commented Jun 12, 2024

If we do this, is there a way to get rid of the ParsedCLIFlags struct as well? Feels like unnecessary duplication.

@YoshiRulz
Copy link
Member Author

YoshiRulz commented Jun 12, 2024

If we do this, is there a way to get rid of the ParsedCLIFlags struct as well? Feels like unnecessary duplication.

Yes, by exposing the Options, returning the ParseResult, and moving the GetValueForOption calls throughout MainForm. I will try to do that for this PR.

@YoshiRulz
Copy link
Member Author

Should --help group the flags semantically? (Re-ordering the list is trivial, unfortunately adding headers isn't.) I chose to list them alphabetically since that's what I'm used to from Unix tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants