Add Uniform Title Field #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add a field for "Uniform Title" to record pages when MARC field 130a is present.
jsavell
reviewed
Jun 27, 2024
| @@ -652,6 +652,14 @@ public function getLanguages() | |||
| return (array)($this->fields['language'] ?? []); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
We've customized this file in the TAMU modules directory. I think adding this change to the file here instead should get the same results and keep future upgrades simpler.
There was a problem hiding this comment.
It currently doesn't work when placed in our TAMU module directory, but you're right that it would make updates easier. I'll investigate what needs to be done to make the local version work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a field for "Uniform Title" to record pages, based on MARC field 130a.