[Issue 380] Data and analytic view container type #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
380-data-and-analytic-view-container-type
branch
from
9b702a7
to
aaa8bea
Compare
ghost
mentioned this pull request
ghost
commented
Aug 15, 2023
| Individual individual = resource.getContent(); | ||
| if (individual != null) { | ||
| if (individual.getProxy().equals(Person.class.getSimpleName())) { | ||
| addResource(resource, new ResourceLink(individual, "docx", "Single Page Bio", "Individual single page bio export")); |
There was a problem hiding this comment.
This will change as these resource links are defined by available export views for display views. As these augments all individual responses I prefer the values be static and bound to the persisted entities. Which will require a bit of design to afford dynamism.
kaladay
previously approved these changes
Aug 15, 2023
jmicah
added a commit
that referenced
this pull request
Oct 12, 2023
* [Issue 328] Resource not found exceptions (#329) * Return null to indicate not found * Add file not found exception handler * Add external asset directory config example * Update README.md * Add index collection name configuration and replace constant * Add initial index health indicator * [Issue 237] Add initial GitHub templates. (#342) * [Issue 347] Add configuration to disable individual document create on batch fail (#348) Co-authored-by: Rincy Mathew <[email protected]> * Add configuration to enable/disable schematizing (#356) * Remove over encapsulation and correct separation of concern (#361) The helper classes in discovery package are violating common principles and are not providing abstraction to multiple implementations of their use. * Refactor research/er age with academic age (#363) * Add initial data and analytics view (#366) The additional properties required for data and analytics UI/UX has yet to be determined. * Add organization id to theme (#365) The organization could be removed and wherever rendered can be updated to fetch the organization by id. Note the non default constructor is for testing purposes. * [Issue 368] Refactor relationship date time interval properties (#369) * Refactor relationship date time interval properties The field types conflicted with property of the same name on Process. * Add eof newline to template file * [Issue 370] Add additional facet entity properties to control UI behavior (#371) * Add expandable/collapsible properties to facet entity * Support open dialog for facets * Update facet test for use dialog getters/setters * Use property paths where applicable in views (#374) * Add sub organization type to organization (#375) * Upgrade Jena lib, remove SDB triplestore support, and minor refactoring (#377) * Remove SDB triplestore support * Upgrade jena libs * Add caffeine as a dependency * Minor refactor and replace deprecation * Remove redundant field type creation * Cleanup triplestore harvester * [Issue 357] Individual medium for harvest/index (#378) * Individual medium for harvest/index and remove field binding from discovery model Note that Individual still uses Solr Java Object binding to SolrInputDocument for indexing. * Remove unused test dependency injection * [Issue 380] Data and analytic view container type (#381) * Add container type to data and analytics view * Update individual model resources * Update tests * Add eof newline to data and analytics default yaml * Update export view names * Fix analytics endpoint mapping for academicAge * Remove authorize for now * Fix copy field duplication (#384) * Docx exporter regression (#388) * Use individual for serialization instead of content * Minor refactor document to individual * Add facets to data and analytics views (#389) * Remove broken workflows (#392) * Upgrade some dependencies (#393) * Use liquibase (#394) * Use liquibase * Fix updating defaults * Update authorizations for data and analytics (#395) * Update authorizations for data and analytics * Add some missing ending newlines * Upgrade to solr docker to 9.3 * Use public tamu smtp as default * Now using stomp without sockjs * Upgrade spring security config * Minor cleanup and expose content disposition header * Fix zip exporter authorization * Prevent template error when type is not present (#397) --------- Co-authored-by: William Welling <[email protected]> Co-authored-by: William Welling <[email protected]> Co-authored-by: Rincy Mathew <[email protected]> Co-authored-by: wwoops <[email protected]> Co-authored-by: William Welling <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally update individual resource model link additions.