Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

June 2023 Sprint #321

Merged
5 commits merged into from
Jul 17, 2023
Merged

June 2023 Sprint #321

5 commits merged into from
Jul 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2023

No description provided.

@ghost ghost requested review from jcreel, rmathew1011 and kaladay July 11, 2023 21:25
jcreel
jcreel previously approved these changes Jul 14, 2023
Copy link
Member

@jcreel jcreel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much approve of the descriptive function and variable names in the new machinery

@ghost ghost force-pushed the june-2023-sprint-staging branch from b7e9f2e to 0a41e50 Compare July 14, 2023 14:29
- Compute total while parsing and add to quantity distribution
- Remove duplicate constant
- Avoid synthetic getter conflict with expected actual getter
- Update banner.txt
- Add some conditionals while getting resource
- Remove unused import
- Fix windows external resource handling
@ghost ghost force-pushed the june-2023-sprint-staging branch from 2ed6e1e to 2680af9 Compare July 17, 2023 12:52
@ghost ghost merged commit 538ce10 into tamu-main Jul 17, 2023
12 checks passed
@ghost ghost deleted the june-2023-sprint-staging branch July 17, 2023 13:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants