Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 307: POWF - to make the expenseClass optional. #310

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Issue 307: POWF - to make the expenseClass optional. #310

merged 2 commits into from
Oct 10, 2023

Commits on Oct 6, 2023

  1. Issue 307: POWF - to make the expenseClass optional. 

    The workflow is failing due to not properly handling existence cases, such as NULL checks.
Provide a helper function `extractResponseArray()` to perform the needed checks.

This change does not determine what to do when required values are not defined.
An error at a different part of the process may occur but such an error will likely be due to bad data.

The decision here is to use `undefined` rather than `null` for the cases where the existence checks fail.
If this is a problem, then this can be changed to `null` instead of `undefined`.
    @kaladay
    kaladay committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ed122c5 View commit details
    Browse the repository at this point in the history

  2. Issue 307: Remove unused parameter. 

    This is no longer being used and I forgot to remove it in the previous commit.
    @kaladay
    kaladay committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    df676fc View commit details
    Browse the repository at this point in the history