Issue 307: POWF - to make the expenseClass optional. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow is failing due to not properly handling existence cases, such as NULL checks. Provide a helper function `extractResponseArray()` to perform the needed checks. This change does not determine what to do when required values are not defined. An error at a different part of the process may occur but such an error will likely be due to bad data. The decision here is to use `undefined` rather than `null` for the cases where the existence checks fail. If this is a problem, then this can be changed to `null` instead of `undefined`.
This is no longer being used and I forgot to remove it in the previous commit.
jeremythuff
approved these changes
Oct 9, 2023
Dbreck-TAMU
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #307
The workflow is failing due to not properly handling existence cases, such as NULL checks. Provide a helper function
extractResponseArray()to perform the needed checks.This change does not determine what to do when required values are not defined. An error at a different part of the process may occur but such an error will likely be due to bad data.
The decision here is to use
undefinedrather thannullfor the cases where the existence checks fail. If this is a problem, then this can be changed tonullinstead ofundefined.