Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Researcher profile tab #95

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Researcher profile tab #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4841a8a
updated untyped component to nav to new tab when researcher link is c…
qtamu Sep 5, 2024
fc7636c
Researcher profile link opens to new tab
qtamu Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/item-page/field-components/metadata-uri-values/metadata-uri-values.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<!-- From upstream DSpace 7 https://github.com/DSpace/dspace-angular/pull/2866/files -->
<ds-metadata-field-wrapper [label]="label | translate">
<a class="dont-break-out" *ngFor="let mdValue of mdValues; let last=last;" [href]="mdValue.value">
<a class="dont-break-out" *ngFor="let mdValue of mdValues; let last=last;" [href]="mdValue.value" [target]="linkTarget">
{{ linktext || mdValue.value }}<span *ngIf="!last" [innerHTML]="separator"></span>
</a>
</ds-metadata-field-wrapper>
8 changes: 8 additions & 0 deletions src/app/item-page/field-components/metadata-uri-values/metadata-uri-values.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ describe('MetadataUriValuesComponent', () => {
const separators = fixture.debugElement.queryAll(By.css('a span'));
expect(separators.length).toBe(mockMetadata.length - 1);
});
// From upstream DSpace 7 https://github.com/DSpace/dspace-angular/pull/2866/files
it('should contain the correct target attribute for metadata links', () => {
const links = fixture.debugElement.queryAll(By.css('a'));
for (const link of links) {
expect(link.nativeElement.getAttribute('target')).toBe('_blank');
}
});
// END of upstream addition

describe('when linktext is defined', () => {

Expand Down
8 changes: 8 additions & 0 deletions src/app/item-page/field-components/metadata-uri-values/metadata-uri-values.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,12 @@ export class MetadataUriValuesComponent extends MetadataValuesComponent {
* The label for this iteration of metadata values
*/
@Input() label: string;

// From upstream DSpace 7 https://github.com/DSpace/dspace-angular/pull/2866/files
/**
* The target attribute for the metadata links.
* Defaults to '_blank' to open links in a new window/tab.
*/
@Input() linkTarget = '_blank';
// END of upstream additions
}
Loading