Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of local Weaver-UI-Core repo, adding support for det… #237

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Aug 24, 2023

This adds two configuration variables:

  1. CI_WUI_BRANCH
  2. CI_WUI_DISABLE_LOCAL_PUBLISH

The CI_WUI_BRANCH should allow for a custom branch to be used in the local Verdaccio NPM hosting. The CI_WUI_DISABLE_LOCAL_PUBLISH should allow for disabling the local Verdaccio NPM hosting.

These should be configurable as per the following documentation:

…ecting the branch or tag name.

This adds two configuration variables:
1) `CI_WUI_BRANCH`
2) `CI_WUI_DISABLE_LOCAL_PUBLISH`

The `CI_WUI_BRANCH` should allow for a custom branch to be used in the local Verdaccio NPM hosting.
The `CI_WUI_DISABLE_LOCAL_PUBLISH` should allow for disabling the local Verdaccio NPM hosting.

These should be configurable as per the following documentation:
- https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context
- https://docs.github.com/en/actions/learn-github-actions/variables#defining-variables-for-multiple-workflows
@coveralls
Copy link

Coverage Status

coverage: 40.103%. remained the same when pulling 4bb54dc on wui-version-github into 48a07ff on main.

@kaladay kaladay marked this pull request as ready for review August 24, 2023 18:48
@kaladay kaladay requested review from a user, rmathew1011 and rhundal7 August 24, 2023 20:24
Copy link

@rhundal7 rhundal7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looks great!!

@kaladay kaladay merged commit 419a759 into main Aug 24, 2023
2 checks passed
@kaladay kaladay deleted the wui-version-github branch August 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants