-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 200] Port custom emails #220
[Issue 200] Port custom emails #220
Conversation
Keep this as draft pending the investigation described in the note "[DSpace] [SPIKE] Verify that customized email templates are being utilized by the server". We are unsure whether the three extra migrated templates will get invoked by the 7.x code. But they all serve important purposes so we need to be sure of what replaces them if they are not getting invoked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if subscription
template file is different from subscriptions_content
.
Check if subscriptions_content is acceptably comparable to legacy subscription.
Please remove subscription
and modify subscriptions_content accordingly if necessary.
https://github.com/TAMULib/DSpace/tree/tamu-dspace-7_x/dspace/config/emails
The alumni_request email template can be ported over with TAMULib/dspace-angular#29.
Unrelated to this PR:
Missing local based file support for email here with public constant pointing the healthcheck email template. Not sure why I18nUtil.getEmailFilename function was not used within Email.getEmail.
References
Description
Ported several TAMU email templates into DSpace 7_x.