Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 200] Port custom emails #220

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

Dbreck-TAMU
Copy link

References

Description

Ported several TAMU email templates into DSpace 7_x.

kaladay

This comment was marked as resolved.

@Dbreck-TAMU Dbreck-TAMU linked an issue Dec 14, 2023 that may be closed by this pull request
@Dbreck-TAMU Dbreck-TAMU marked this pull request as draft December 19, 2023 16:49
@jcreel
Copy link
Member

jcreel commented Dec 21, 2023

Keep this as draft pending the investigation described in the note "[DSpace] [SPIKE] Verify that customized email templates are being utilized by the server".

We are unsure whether the three extra migrated templates will get invoked by the 7.x code. But they all serve important purposes so we need to be sure of what replaces them if they are not getting invoked.

@wwelling wwelling changed the base branch from tamu-dspace-7_x to dspace-7_x-sprint4-staging January 3, 2024 15:08
@wwelling wwelling changed the title 200 port custom emails [Issue 200] Port custom emails Jan 5, 2024
Copy link

@wwelling wwelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if subscription template file is different from subscriptions_content.

Check if subscriptions_content is acceptably comparable to legacy subscription.

Please remove subscription and modify subscriptions_content accordingly if necessary.

https://github.com/TAMULib/DSpace/tree/tamu-dspace-7_x/dspace/config/emails

The alumni_request email template can be ported over with TAMULib/dspace-angular#29.

Unrelated to this PR:
Missing local based file support for email here with public constant pointing the healthcheck email template. Not sure why I18nUtil.getEmailFilename function was not used within Email.getEmail.

dspace/config/emails/bte_batch_import_error Show resolved Hide resolved
dspace/config/emails/bte_batch_import_success Show resolved Hide resolved
dspace/config/emails/subscription Outdated Show resolved Hide resolved
@wwelling wwelling marked this pull request as ready for review January 23, 2024 06:12
@Dbreck-TAMU Dbreck-TAMU merged commit 8f8d5f3 into dspace-7_x-sprint4-staging Jan 23, 2024
16 checks passed
@wwelling wwelling deleted the 200-port-custom-emails branch January 24, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSpace 7 Upgrade] Port custom emails to new email templates
7 participants