Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Deduplicate read enable generation. #108

Closed
wants to merge 1 commit into from
Closed

src: Deduplicate read enable generation. #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/peakrdl_regblock/readback/generators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ def process_external_reg(self, node: RegNode) -> None:

def process_reg(self, node: RegNode) -> None:
current_bit = 0
rd_strb = f"({self.exp.dereferencer.get_access_strobe(node)} && !decoded_req_is_wr)"
# Create per-register read enable
rd_strb = self.exp.dereferencer.get_access_strobe(node)
rd_en = f"{rd_strb.split('.')[-1]}_rd_en"
self.add_content(f"logic {rd_en} = {rd_strb} && !decoded_req_is_wr;")
# Fields are sorted by ascending low bit
for field in node.fields():
if not field.is_sw_readable:
Expand All @@ -151,7 +154,7 @@ def process_reg(self, node: RegNode) -> None:
# Field gets bitswapped since it is in [low:high] orientation
value = do_bitswap(value)

self.add_content(f"assign readback_array[{self.current_offset_str}][{field.high}:{field.low}] = {rd_strb} ? {value} : '0;")
self.add_content(f"assign readback_array[{self.current_offset_str}][{field.high}:{field.low}] = {rd_en} ? {value} : '0;")

current_bit = field.high + 1

Expand Down