-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Inquiry API / controller test / RestDocs 구현 #75
Open
shj1081
wants to merge
20
commits into
feat/45-inquiry-api/base
Choose a base branch
from
feat/45-inquiry-api/1
base: feat/45-inquiry-api/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 과제 제안 API PR의 mail 관련 설정 참고
* fix: redirect uri 추가 * fix: access-token cookie응답으로 변경 * fix: cookie domain localhost로 변경 * fix: redirect uri 방식 변경 * fix: redirect uri 방식 변경 * fix: secure 옵션 추가 * fix: 프론트 로그인 콜백주소 변경 * chore: config typo * refactor: Login 테스트코드 리팩토링 * refactor: 학번 uniqueness 삭제
simta1
reviewed
Aug 28, 2024
src/main/java/com/scg/stop/project/controller/ProjectController.java
Outdated
Show resolved
Hide resolved
yesjuhee
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 문의/문의 답변이 수정된 경우 메일 발송 여부 -> 일단은 지금처럼 두고 추후 요청이 있을 경우 수정하는걸로 하죠!
- 문의의 경우 조회 시 작성자를 user 의 name 으로 반환하도록 하였는데, userId 도 함께 반환하는 것이 더 적절한지 고려가 필요할 것 같습니다 -> 현재 피그마상으로는이름만 있어도 될 것 같습니다.
src/main/java/com/scg/stop/project/controller/ProjectController.java
Outdated
Show resolved
Hide resolved
src/test/java/com/scg/stop/inquiry/controller/InquiryControllerTest.java
Outdated
Show resolved
Hide resolved
yesjuhee
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
develop 브랜치 머지하고
html 파일들 빌드해서 커밋하고
최종 머지하면 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작성자: @shj1081
#45
체크 리스트
작업 내역
Inquiry API 구현 / Controller test / RestDocs
Exception code
탈퇴한 회원 case
authorName = "탈퇴한 회원"
처리 ([FEAT] user 관련 api 구현 #60 pre remove 대응)비고
spring.mail.adminEmail
추가 필요user
의name
으로 반환하도록 하였는데,userId
도 함께 반환하는 것이 더 적절한지 고려가 필요할 것 같습니다projects/{projectId}/inquiry
를 통해 생성하지만 controllerTest 의 경우 임시로InquiryControllerTest
에 두었습니다