tweak master comp behaviour and parameters #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-m-adams
force-pushed
the
bugfix/master_comp_params
branch
from
c311592 to
66b0e92
Compare
m-m-adams
force-pushed
the
bugfix/master_comp_params
branch
from
b5afe65 to
10a313b
Compare
PaulFreund
reviewed
Nov 9, 2023
PaulFreund
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak params in response to #693, fix some issues caused by tiny sample windows
Threshold range lowered to be more usable
Maximum attack/release times increased
DC offset removal removed, it no longer works as sample windows can be single samples post #682
Extra gain reduction while clipping removed, it no longer works without DC offset removal