Fixed Sticky Shift Conflict with Shift Select Encoder Acceleration #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed conflict when Sticky Shift functionality is enabled with the Shift Acceleration that was added in SynthstromAudible#636 Fixed it by calling isButtonPressed instead of isShiftButtonPressed in order to check if the Shift button is actually being pressed rather than "stickily pressed."
seangoodvibes
changed the title
m-m-adams
approved these changes
Oct 31, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Fixed Sticky Shift Conflict (#661) Fixed conflict when Sticky Shift functionality is enabled with the Shift Acceleration that was added in #636 Fixed it by calling isButtonPressed instead of isShiftButtonPressed in order to check if the Shift button is actually being pressed rather than "stickily pressed." * enable filters for testing --------- Co-authored-by: Sean Ditny <[email protected]>
seangoodvibes
deleted the
Fix-Sticky-Shift-Conflict-with-Shift-Menu-Acceleration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed conflict when Sticky Shift functionality is enabled with the Shift Select Encoder Acceleration that was added in #636
Fixed it by calling isButtonPressed instead of isShiftButtonPressed in order to check if the Shift button is actually being pressed rather than "stickily pressed."