Master comp UI improvements #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Update Midi CC Value Range, Bug Fix for Midi CC Assignment in Automation Overview (SynthstromAudible#636) * Display Mod Encoder Values with Popup Added code to view.cpp to display new value corresponding to the parameter that the mod encoder being turned is assigned to. Removed display popup code for from MidiParamCollection and ExpressionParamSet as its no longer required. * Fixed value displayed for Pan Changed display of Pan values from: 0 - 128 to -64 - +64 * Dbt Format * Updated Menu Value Adjustment Range Updated the Value Adjustment range in the menu from 0 - 50 to 0 - 128. For Pan, the range changed from -32 to +32 to -64 to + 64 * Updated Param Value Range for Patch Cables Factored out the constants for Patch Cables Updated range from -50 to.+50 to -128 to +128 to align with the +128 range displayed for params in the regular menu's * Adjust displayed of popups when in soundEditor When in soundEditor, if you turn a modEncoder, it will only display a pop up when you're turning a modEncoder that is mapped to a parameter that is different from the parameter being edited in the soundEditor menu * Ignore modEncoder turns for Midi above 127 Currently there is a bug where turning the knob to the 128th position acts as sending 127 twice. Instead of doing that, I have set it to ignore modEncoderActions for MIDI Instrument Clips that result in the knob turning to 128 or turning from 128 to 127. * Dbt Format * Update Midi CC Value Range in Automation Instrument Clip View Changed Midi CC Value Range in Automation Instrument Clip View from 0 - 128 to 0 - 127. * dbt format * Bug Fix + Documentation Documented some changes to Automation Instrument Clip View for Midi CC values Fixed issue where you could not assign a Midi CC to a Mod Encoder with the Select Encoder when in the Automation Overview * Adjustments - Added description of improvements to community_features.md - Reversed changes to compressor attack / release menu items per feedback from @m-m-adams - Updated selectEncoderAction when in Menu to adjust menu values by +/- 2 by default. To adjust menu values by +/- 1, you just need to hold shift. * Fixed quantized stutter crashing Fixed bug with quantize stutter crashing * Fixed selectEncoder default acceleration Changed default acceleration for Select Encoder back to +/- 1 as changing it to +/- 2 affects scrolling through menu items. * Adjusted select encoder acceleration Per feedback, adjusted select encoder acceleration to +/- 5 while holding shift * Updated display for stutter quantization if turning stutter mod encoder and stutter quantize is enabled, display stutter quantization instead of knob position * dbt format * Fixed stutter display When pressing down on the stutter mod encoder and turning the knob, the knob now displays the fine tuned stutter amounts rather than the quantized amounts. * Updated knobPos displayed 1) Changed menu range back to 0 - 50 (Pan displays -25 to +25) 2) Changed mod encoder pop-ups to display the 0-50 range by converting the 0-128 knob positions to 0 - 50 (with the exception of Pan which displays -25 to +25) 3) Updated parameter values displayed in Automation View to use the 0 - 50 range (except for MIDI which stays with 0 - 127) 4) Update Pan in Automation View to display the -25 to +25 range Changed range from 0 - 128 to 0 - 50 5) Some cleanup of function definitions in Automation View by passing the InstrumentClip and Instrument variables where needed * Updates to documentation
use new max menu constant where possible
PaulFreund
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves ratio/attack/release to lower knob in full mode. Click to change and a popup shows where you are, matching the modfx ui
Adds a timeout before switching from levels to the meter
Adds a popup with the current value to match #636