Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory management improvements #638

Merged
merged 20 commits into from
Oct 24, 2023
Merged

Conversation

PaulFreund
Copy link
Collaborator

@PaulFreund PaulFreund commented Oct 22, 2023

Join venture with @m-m-adams :D

  • Reorganizes all GMA allocations or comments them if a possible change was not done
  • Separates Stealable memory (56Mb) into it's own region
  • Creates an 8Mb external region for all slower non stealable memory
  • Moves FX, Delay and Grain FX buffer to extenral memory (only on Grain Fx this has a minor negative performance impact)
  • Moves all parameters to external memory without negative impact massively increasing the amount of clips that can be created This seems to make the UI sluggish and leads to culling on copying kits
  • Smarter padding and allocations to power of two
  • More readable allocation function names

(hopefully) fixes: #462, #492

@PaulFreund PaulFreund changed the title Hunting for situations where internal and external RAM gets full Memory management improvements Oct 23, 2023
@PaulFreund PaulFreund marked this pull request as ready for review October 23, 2023 15:10
Copy link
Collaborator

@stellar-aria stellar-aria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me, @PaulFreund said this was tested pretty stringently so I'm going to go off that and merge it.

@stellar-aria stellar-aria merged commit c8516f0 into release/1.0 Oct 24, 2023
@m-m-adams m-m-adams deleted the bugfix/huntingMemoryProblems branch October 25, 2023 15:01
@Icoustic
Copy link

Join venture with @m-m-adams :D

* Reorganizes all GMA allocations or comments them if a possible change was not done

* Separates Stealable memory (56Mb) into it's own region

* Creates an 8Mb external region for all slower non stealable memory

* Moves FX, Delay and Grain FX buffer to extenral memory (only on Grain Fx this has a  minor negative performance impact)

* ~Moves all parameters to external memory without negative impact massively increasing the amount of clips that can be created~ This seems to make the UI sluggish and leads to culling on copying kits

* Smarter padding and allocations to power of two

* More readable allocation function names

(hopefully) fixes: #462, #492

Nice, I'm late to the party. Gonna test and see if #462 no longer is an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants