General CMake cleanup #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started testing and right now for the Release build It seems we have less symbols in our elf file now, not yet sure which change is the reason |
|
Unfortunately right now this change costs me 3-5 Voices in the pure synth voice test |
|
At least 3 of them are down to LINKER:--sort-common
LINKER:--sort-section=name |
stellar-aria
force-pushed
the
build-improvement-release
branch
from
bf05372 to
b8c1de4
Compare
|
Still 1-2 Voices I'd like to account for, need more investigation. Raw rendering seems to be the same speed |
PaulFreund
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some cleanup of the CMake build a bit and makes the built-in firmware semver depend on CMake project version for a single consistent source.
There is now a
MAINTAINER_MODEoption to enable the absolute glut of warnings we actually have lurking about.-fanalyzerin particular has quite a bit to say about some uninitialized variables that get used in places...There should be no changes to the actual outputted firmware.
Please double check that firmware size is consistent and has not changed, if it has I'll revert the built-in CMake LTO removal (which in theory was getting overridden anyways)