-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master compressor #630
Master compressor #630
Conversation
1e07624
to
964084e
Compare
Thanks for digging in to this! As per the video I posted on Discord, I've noticed a few things on 7SEG when testing this compressor:
|
Thanks for the feedback! Some of those I'll handle in a different PR to switch to the proper deluge parameter management system, but I'd like to get this merged to solidify the audio side before that's done
Both are bugs in the interaction between the older compressor code and this one. I'll fix in this PR
Tracking but out of scope for this PR, it'll fix itself in the main deluge parameter system
Will fix in this PR
I'll fix that too, not sure if it's good or not but it seems counter intuitive |
11e9116
to
1340af7
Compare
Code looks good but need to get rid with that interaction with sidechain :) |
Gonna see if I can integrate the master comp with the 32->24 bit conversion to optimize the headroom |
02a5a26
to
87310c0
Compare
Forgot to press approve but did review it ;) |
RMS calculation is done in floats due to the number of sqrt/logs required, rest of the compressor is integer based on extending the existing sidechain envelopes
UI:
in song or arranger view, affect entire sidechain is a one knob compressor, lowering the threshold and auto increasing make up gain. Pressing sidechain will flash COMP, and switch to showing gain reduction on the top LED meter and input volume on the bottom. They are not identically scaled in order to make better use of the lights. While in this mode the bottom knob (reverb) adjusts the ratio, ranging from about 1/8 to infinity/brick wall limiting
Attack and release can be adjusted on the affect entire attack/release knobs since they're otherwise unused.
I have removed the community settings as there is no longer a downside to the compressor, it's approximately 10x faster than in #583
Todo:
In a future PR I'll move this into global effectable proper so that it can properly leverage the parameter system and kits can have their own compressor as well. Currently it relies on the fallthrough method for gold knobs without params attached