Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick bug fixes #1560

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Cherry pick bug fixes #1560

merged 5 commits into from
Mar 23, 2024

Conversation

m-m-adams
Copy link
Collaborator

No description provided.

seangoodvibes and others added 5 commits March 23, 2024 12:26
Fixed bug where deluge would become unresponsive if you were stuttering while launching a clip

Went back to the 4.1.4 codebase where this issue was not present and noticed that we removed a bit of code (I assume accidentally) that was needed to prevent this issue from happening. So I just added that code back.
Fixed bug where sound menu would be unresponsive if you try to enter the menu while holding the horizontal encoder

Fixed it by blocking menu entry when currentUIMode is not none
Fixed selection of patch cable decimal number pos for editing with the horizontal encoder

If automation view is the underlying root UI, it will only engage horizontal scrolling if you've reached the far left or far right edit pos for the decimal patch cable number

also disabled scrolling patch cable number if you're holding down horizontal encoder as it makes zooming in/out in automation view more cumbersome
Disabled interacting with sidebar while VU meter is displayed

Volume mod button now blinks when VU meter is on and being displayed

update documentation
@m-m-adams m-m-adams marked this pull request as ready for review March 23, 2024 16:27
Copy link
Contributor

Test Results

9 tests   9 ✅  0s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 177cdba.

@m-m-adams m-m-adams merged commit 357c65b into release/1.1 Mar 23, 2024
5 checks passed
@m-m-adams m-m-adams deleted the cherry-picker branch March 25, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants