Bugfix - When changing midi channel on a Midi Preset, show it as popup #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
Test Results9 tests 9 ✅ 0s ⏱️ Results for commit e039687. ♻️ This comment has been updated with latest results. |
m-m-adams
deleted the
cherry-pick-release/1.1-d7fea6c9af451ae57ef3f630d7733a9179824812
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1466
by checking if the name of a midi output is set to something, it means we are dealing with a saved MIDI Preset, so the name of the preset is always visible, even when changing midi channels using the select encoder (so you can't see what channel you are setting). This checks for that and in that case, shows the midi channel being changed in a popup as a fallback mechanism, so the users knows which channel they are setting
To cherry-pick!