Numerous bugfixes being cherry picked at once #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Rhythm to Automation View Select Scrolling * Move Comments for Better Formatting
Fixed bug where updated multi ranges would not re-render the underlying keyboard view which highlights the notes included in the multi range white.
Adjusted display of negative values in mod matrix menu so that 1 decimal place is not cut off.
Removes repeats popup that sticks around if you're holding section pad while previewing or entering a clip
Fixed code for finding patch param shortcut for mod matrix menu and patch cable menu shortcut blinking Renamed sidechain source name from "comp" to "side" renamed sidechain level source name from "postrvlvl" to "side level"
Fixed highlighting around left / right range values in multi range menu Fixed spelling of word highlight in a few areas
Test Results9 tests 9 ✅ 0s ⏱️ Results for commit 614cdbf. ♻️ This comment has been updated with latest results. |
* Don't allow converting audio clip to instrument clip Converting audio clip to instrument is very problematic, thus it is better to eliminate this behaviour and instead direct users to delete the audio clip and create a new clip instead of going through the "nice to have" conversion process. * Document change * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.