Bugfix kit row audition pad rendering in automation view and kit row audition pad usage in menu #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
Test Results9 tests 9 ✅ 0s ⏱️ Results for commit 5756467. |
m-m-adams
deleted the
cherry-pick-release/1.1-aa3577efa1efa84bf3cf5bcad84811ccd579eef9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1497
The bug: Kit row selection which is rendered on audition pads was being turned off in automation view.
The fix: only turn off LED's if you're not in instrumentClipView or automationInstrumentClipView and if affect entire is on
Also removed a restriction added in another PR that didn't let you audition non-selected drum pads while in the menu