Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bugfix - Stutter makes deluge unresponsive (#1556)
Browse files Browse the repository at this point in the history
Fixed bug where deluge would become unresponsive if you were stuttering while launching a clip

Went back to the 4.1.4 codebase where this issue was not present and noticed that we removed a bit of code (I assume accidentally) that was needed to prevent this issue from happening. So I just added that code back.
seangoodvibes authored and m-m-adams committed Mar 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 5acf5a9 commit 62bde45
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/deluge/gui/views/view.cpp
Original file line number Diff line number Diff line change
@@ -2561,6 +2561,14 @@ ActionResult View::clipStatusPadAction(Clip* clip, bool on, int32_t yDisplayIfIn
// No break
case UI_MODE_CLIP_PRESSED_IN_SONG_VIEW:
case UI_MODE_STUTTERING:
// this code is needed to allow users to launch clips while stuttering
// without it the deluge becomes unresponsive if you try to launch a clip while stuttering
// this is because it gets stuck in the stuttering UI mode and can't get out
if (on) {
sessionView.performActionOnPadRelease = false; // Even though there's a chance we're not in session view
session.toggleClipStatus(clip, NULL, Buttons::isShiftButtonPressed(), kInternalButtonPressLatency);
}
break;
case UI_MODE_HOLDING_STATUS_PAD:
if (on) {
enterUIMode(UI_MODE_HOLDING_STATUS_PAD);

0 comments on commit 62bde45

Please sign in to comment.