Support Phantom wallet #698
Conversation
|
Hello, @maximgeerinck 👋 If I am getting it correctly this Phantom Wallet support PR is not finished because there is no way to download phantom wallet as it's not open-source. The plan from your side was to wait until it is open-sourced. Just want to let you know that you can use this chrome extension to extract the source code from any chrome extension as ZIP file. Also, you can use this website to download the source code. Also, check this GitHub gist on how to download the source code for any Chrome extension. CRX Viewer will allow you to download the source code for any Chrome extension (repo) Thanks, please let me know if you need any help! |
|
We've added a way to download a phantom crx and install it |
There was a problem hiding this comment.
Many tests are failing when running PROVIDERS=phantom,[email protected] pnpm run test:e2e
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
commands/metamask.js
Outdated
| @@ -1332,13 +1490,14 @@ | |||
| await metamask.goToAdvancedSettings(); | |||
| } | |||
| } | |||
| if ((await playwright.metamaskWindow().locator(toggleOn).count()) === 0) { | |||
| await playwright.waitAndClick(toggleOff); | |||
| if (!(await playwright.windows(PROVIDER).locator(toggleOn).count()) === 0) { | |||
Check warning
Code scanning / CodeQL
Comparison between inconvertible types
commands/phantom.js
Outdated
| @@ -0,0 +1,551 @@ | |||
| const log = require('debug')('synpress:phantom'); | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
There was a problem hiding this comment.
| const log = require('debug')('synpress:phantom'); |
|
@maximgeerinck Tests are failing due to the recent changes (mostly adding new networks), can you please take a look? Many thanks for considering my request. |
package.json
Outdated
| "name": "@phantom/synpress", | ||
| "version": "4.0.0-alpha.22", |
There was a problem hiding this comment.
| "name": "@phantom/synpress", | |
| "version": "4.0.0-alpha.22", | |
| "name": "@synthetixio/synpress", | |
| "version": "3.7.0", |
Synthetixio dev
fix: remove export from phantom-js
fix: add a wait for get started button
Motivation and context
Add support for phantom wallet.
List of current features:
EXTRA:
@TODO:
Quality checklist
Future Ideas