Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update acceptMetamaskAccess() to accept a list of account indexes. #686

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Mar 15, 2023

Motivation and context

When connecting the dApp to MetaMask, It will be better to have the ability to select a list of accounts or a single account to connect the dApp to it.

cy.acceptMetamaskAccess({ 
  accountIndexes: [1, 2], // Will connect the dApp to the 1st and 2nd account 
});

Other useful info

When using this feature, the default selected account (mostly the active one) will be deselected if needed.
The allAccounts flag is designed to overwrite the accountIndexes flag when it is set to true

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

@neuodev neuodev requested a review from drptbl March 15, 2023 09:14
@neuodev neuodev self-assigned this Mar 15, 2023
@neuodev neuodev added the enhancement New feature or request label Mar 15, 2023
@cypress
Copy link

cypress bot commented Mar 15, 2023

Passing run #391 ↗︎

0 174 0 0 Flakiness 0

Details:

Update `acceptMetamaskAccess()` to accept a list of account indexes.
Project: synpress Commit: d6b5d13c8b
Status: Passed Duration: 10:34 💡
Started: Aug 18, 2023 4:24 PM Ended: Aug 18, 2023 4:35 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@drptbl drptbl removed their request for review February 25, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants