Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Optional caching for tests and enable tests for windows #1155

Merged
merged 33 commits into from
Jul 9, 2024

Conversation

Seroxdesign
Copy link

@Seroxdesign Seroxdesign commented Jun 25, 2024

Motivation and context

Currently, Synpress requires users to build a cache of browser contexts with pre-configured wallets before running tests. This task aims to remove this constraint, allowing developers to run tests directly without the need for a pre-built cache.

Does it fix any issue?

SYN-51 & Helps with Windows

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:17am

@Seroxdesign
Copy link
Author

Currently looking into how we will take the input for cache option from user, RN it's hardcoded but we can go with input, env, and different cli commands

packages/cache/src/defineWalletSetup.ts Outdated Show resolved Hide resolved
wallets/metamask/environment.d.ts Outdated Show resolved Hide resolved
wallets/metamask/test/e2e/PPOM.spec.ts Outdated Show resolved Hide resolved
wallets/metamask/src/config.ts Show resolved Hide resolved
wallets/metamask/src/config.ts Outdated Show resolved Hide resolved
wallets/metamask/src/fixtures/metaMaskFixtures.ts Outdated Show resolved Hide resolved
@Seroxdesign
Copy link
Author

NOTE:

We need to update synpress-cache npm package and versioning in package.json before we merge this

@Seroxdesign Seroxdesign changed the base branch from new-dawn to new-dawn-dev July 9, 2024 09:17
@Seroxdesign Seroxdesign merged commit af4405a into new-dawn-dev Jul 9, 2024
8 of 9 checks passed
@Seroxdesign Seroxdesign deleted the feat/optional-cache branch July 9, 2024 09:17
matstyler added a commit that referenced this pull request Jul 11, 2024
@matstyler matstyler restored the feat/optional-cache branch July 11, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants