Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add wait for methods #1154

Merged
merged 4 commits into from
Jul 1, 2024
Merged

✨ feat: Add wait for methods #1154

merged 4 commits into from
Jul 1, 2024

Conversation

Seroxdesign
Copy link
Collaborator

@Seroxdesign Seroxdesign commented Jun 20, 2024

Motivation and context

Added custom wait for load page with Metamask, and used the method to check if scrollbar exists

Does it fix any issue?

  • adds wait for
  • fixes the pesky signature issue

Other useful info

  • should be useful for more metamask tests

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:18pm

@Seroxdesign Seroxdesign changed the title lint and test ✨ feat: Wait for Jun 20, 2024
@Seroxdesign Seroxdesign changed the title ✨ feat: Wait for ✨ feat: Add wait for methods Jun 20, 2024
@drptbl drptbl merged commit c0348f5 into new-dawn Jul 1, 2024
9 checks passed
@drptbl drptbl deleted the feat/wait-for branch July 1, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants