-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: Cypress integration #1117
✨ feat: Cypress integration #1117
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cypress.Commands.add( | ||
'setupMetamask', | ||
( | ||
secretWordsOrPrivateKey = 'test test test test test test test test test test test junk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, separate the config from the cypress as we will use it for other configs as well :)
@@ -22,11 +23,15 @@ | |||
"lint-staged": { | |||
"package.json": "sort-package-json" | |||
}, | |||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using mono repo to store these dependencies, try to move it to an example with cypress use case
module.exports = defineConfig({ | ||
e2e: { | ||
setupNodeEvents(on, config) { | ||
// implement node event listeners here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use test dapp (running for playwright in the example).
@@ -0,0 +1,31 @@ | |||
import { configure } from '@testing-library/cypress'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to build cypress implementation into the current tool structure (monorepo, components separation etc)
@matstyler thanks for the comments, I will get those issues resolved, just a warning that progress is going to be slow on this as I'm currently working full-time but will make sure to get this done before EOM |
Sure, thank you for the contribution. You can use initial configuration I created here - #1118. |
Motivation and context
We would like to integrate with Cypress long term, to start this PR will run existing playwright tests via Cypress.task
Does it fix any issue?
N/A
Other useful info
This is a WIP
Quality checklist