Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop transitively depending on Cypress #1100

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Stop transitively depending on Cypress #1100

wants to merge 1 commit into from

Commits on Feb 7, 2024

  1. Stop transitively depending on Cypress 

    Due to a design limitation in DefinitelyTyped, it doesn't support
`peerDependencies`. This means that Synpress, even when used with
Playwright, transitively depends on Cypress, and installs it for
its users.

PRs that try to fix it get closed:

- DefinitelyTyped/DefinitelyTyped#67000 (review)
- DefinitelyTyped/DefinitelyTyped#44962

I moved `@types/testing-library__cypress` to `peerDependencies`.
    @hasparus
    hasparus committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bb78f4f View commit details
    Browse the repository at this point in the history