Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link http://vows.sbolstandard.org/glyph/SO:0000031/png #188

Open
tcmitchell opened this issue Apr 14, 2022 · 6 comments
Open

Broken link http://vows.sbolstandard.org/glyph/SO:0000031/png #188

tcmitchell opened this issue Apr 14, 2022 · 6 comments
Assignees
@jamesscottbrown

Comments

@tcmitchell
Copy link
Contributor

The broken link http://vows.sbolstandard.org/glyph/SO:0000031/png appears on https://sbolstandard.org/sbol-visual-ontology/, and it can be searched for on the page. It resolves to https://synbiodex.github.io/sbol-visual-ontology/Glyphs/SequenceFeatures/aptamer/aptamer.png and yields a 404 not found error.

@goksel what is the right fix for this? Is there something wrong with the link itself? Or is there something wrong at the SBOL Visual end? We would like to fix this link if possible.

The link http://vows.sbolstandard.org/glyph/SO:0000031/svg works, it is the /png version that does not.
This was referenced Apr 14, 2022
Closed
Merged
@cjmyers cjmyers assigned LukasBuecherl and unassigned Fontanapink Sep 14, 2022
@cjmyers
Copy link
Contributor

cjmyers commented Sep 14, 2022

Remove the /png example

@dissys
Copy link

dissys commented Sep 14, 2022

Let's remove the example with the png file. The link will work if a repository folder has a png file.

@cjmyers
Copy link
Contributor

cjmyers commented Sep 21, 2022

https://manpages.ubuntu.com/manpages/trusty/man1/rsvg-convert.1.html

@cjmyers
Copy link
Contributor

cjmyers commented Sep 21, 2022

https://github.com/SynBioDex/SBOL-visual/tree/master/Glyphs

@cjmyers
Copy link
Contributor

cjmyers commented Sep 21, 2022 •
edited
Loading

Need to run a new release of the SBOL Visual after this is done

@cjmyers
Copy link
Contributor

cjmyers commented Sep 28, 2022

Need to create the png's as part of the release

tcmitchell added a commit that referenced this issue Feb 3, 2023
@tcmitchell
Remove the PNG examples from SBOL Visual Ontology
ba63c4f 
The PNG examples do not work. The collective decision is to remove the
PNG examples and leave the SVG examples.

See #188
@tcmitchell tcmitchell mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesscottbrown jamesscottbrown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the PNG examples from SBOL Visual Ontology SynBioDex/SbolStandardWebsite
7 participants
@goksel @jamesscottbrown @tcmitchell @cjmyers @Fontanapink @dissys @LukasBuecherl