-
Notifications
You must be signed in to change notification settings - Fork 69
Fix Dutch (NL) translations + filename #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bocharsky-bw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to stick to the same format for all translation files
| <trans-unit id="1"> | ||
| <source>%count% year|%count% years</source> | ||
| <target>{count, plural, =0 {0 jaar} one {1 jaar} other {# jaren}}</target> | ||
| <target>%count% jaar|%count% jaar</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct translation should be this one?
| <target>%count% jaar|%count% jaar</target> | |
| <target>%count% jaar|%count% jaren</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, yes, and no. I actually had to change this back to "jaar" after accidentally putting in "jaren" - plural of "jaar" is indeed "jaren", but when we (being, the Dutch) say something about multiple years, there's some weird rules going on. We say "18 jaar" and not "18 jaren".
"That took 2 years and 1 months" will become "Dat duurde 2 jaar en 4 maanden". If we then say "Many years" we would say "Veel jaren" instead of "Veel jaar"... I don't know why or what this is called - I'm no linguist, but I'm native Dutch :+)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, even "thousands of years" would be "duizenden jaren" while "2000 years old" would be "2000 jaar oud". "2000 jaren oud" also works, sounds less strange than "3 jaren", but also sounds off to me. I'd be happy to hear if some linguist has answers about this phenomenon :+)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobQuistNL Oh, interesting! It was just something I noticed, so I was not sure if that change was accidental or on purpose :) I don't know Dutch at all, so even won't argue with it :D Thanks for the detailed explanation ;)
|
Thank you! |
This fixes some issues with translation (because of the filename), and there were some weirdly formatted translations in the duration.