-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile with Java 11 and update to gradle 8.4 #96
base: gradle-build-java-11
Are you sure you want to change the base?
Compile with Java 11 and update to gradle 8.4 #96
Conversation
Thank you @Ao-senXiong for your contributions. I have a couple of comments on this pull request:
|
@Ao-senXiong , thank you for your contributions. Things look good to me. Here are some comments on the ReadMe
|
I updated this PR with new build instructions for Java 11 https://github.com/SymbolicPathFinder/jpf-symbc/pull/96/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5. Please review it when you have time. I did not update the docker section because I did not touch it yet. After merge deprecated API PR, I will update the README.md again with new installation message. |
My local works fine, are you using Java 11 and gradle 8.4? symbolic.min_int=-2147483648 |
@Ao-senXiong , I am still seeing references to Java 8 and Gradle 6.9 in many occurrences in the ReadMe. Please fix all occurrences. |
Okay, thanks! I think some of the java 8 ocurrence was in the detailed instructions section and docker section. I have not touched the docker image for spf before. I guess we need to create new docker image for java 11... |
No description provided.