[Adr] Kernel events vs controllers #500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Nov 19, 2022
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
lchrusciel
reviewed
Nov 24, 2022
There was a problem hiding this comment.
I've tried to influence the file, but I'm lost with the problem we want to solve with it. I was thinking about DTO support at the beginning, but DTOs are not even mentioned here. The usage of kernel events can be discussed without mentioning one controller per action. Let's make a call tomorrow, discuss it and try to build ADR based on that :)
Comment on lines
+9
to
+10
| ResourceController has all the actions, a lot of pretty similar code on each action and hard to maintain/test. | ||
| and it is not flexible enough in its behavior. |
There was a problem hiding this comment.
Suggested change
| ResourceController has all the actions, a lot of pretty similar code on each action and hard to maintain/test. | |
| and it is not flexible enough in its behavior. | |
| Over the years ResourceController become really bloated. It has all the actions, and a lot of pretty similar code on each of them and the default approach to extend its logic is to extend the class. This class has 17 dependencies, which makes it hard to maintain and test. Moreover, some dependencies are not needed for every method call. As a result, this class does not follows SOLID principles and we want to improve its desing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.