Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to define attachment filename #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ability to define attachment filename #141

wants to merge 1 commit into from

Conversation

adpeyre
Copy link

@adpeyre adpeyre commented Jun 8, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@adpeyre adpeyre requested a review from a team as a code owner June 8, 2022 08:08
@adpeyre
Copy link
Author

adpeyre commented Jun 14, 2022

Merge and release soon ? :)

@vvasiloi
Copy link

My colleagues might ask for a test, but let's find it out. @Zales0123 WDYT about this one?

@Zales0123
Copy link
Member

Hello @adpeyre 🖖 Yes, covering it with tests would be needed. Not only unit tests (PHPSpec) but also functional (as we already have them introduced). Moreover, as we already have support for SymfonyMailer as well, we would need to add such a feature in this adapter too.

But the feature proposal itself is nice 👌 Let me know if you need any help 🚀

@Zales0123 Zales0123 added the Feature New feature proposals. label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvasiloi vvasiloi vvasiloi approved these changes

Assignees
No one assigned
Labels
Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adpeyre @vvasiloi @Zales0123