[TwigExtra] Escape potential html in test attributes #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
reviewed
Apr 23, 2025
loic425
reviewed
Apr 25, 2025
| @@ -43,7 +43,9 @@ function (array $attributes): array { | |||
| $result = []; | |||
|
|
|||
| foreach ($attributes as $name => $value) { | |||
| $result[sprintf('data-test-%s', $name)] = (string) $value; | |||
| $escapedValue = htmlspecialchars((string) $value, \ENT_QUOTES | \ENT_SUBSTITUTE, 'UTF-8'); | |||
There was a problem hiding this comment.
My main opinion is that it'd be better to escape this in Twig itself to use escaper strategy. but maybe it'd be overkilled.
There was a problem hiding this comment.
This won't be escaped in Twig because we're adding ['is_safe' => ['html']]. This tells Twig's escaper that the content is safe HTML, so it won't apply automatic escaping
There was a problem hiding this comment.
other option is to add in every twig
{{ sylius_test_html_attribute('test-button', value|escape) }}
There was a problem hiding this comment.
I'm wondering if there are a lot test html that have this value. A lot of them are just empty data test attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.