Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Custom filter fix typos #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stlgaits
Copy link
Contributor

No description provided.

@@ -1,7 +1,7 @@
Creating custom filter
Creating custom filters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one. While it sounds more natural, do we need to rename file and change entry at table of contents at index.md? And it should be synced with other files like custom_action, custom field type, custom bulk action

WDYT @loic425

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point (I forgot to change the links in grid/index.md !). In my opinion, they should all be plural or they could all have an article (so 'creating a custom filter' / 'creating a custom action' ...) because it sounds more natural, even though it is correct without, but it's up to you guys :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants