Test & improve SchemaValidator #109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohrerF
commented
May 22, 2023
| @@ -189,6 +189,7 @@ internal static class ValueHelper | |||
| public static Dictionary<string, object?> DeserializeDictionary(JsonElement element, IType type) | |||
| { | |||
| var dictionary = new Dictionary<string, object?>(); | |||
| // TODO: fix this for unionTypes | |||
There was a problem hiding this comment.
Union Types are currently not working
RohrerF
commented
May 22, 2023
|
|
||
| [Fact] | ||
| // TODO: null violations should somehow have a better error | ||
| public void ValidateValues_PrimitivesNullViolation_Invalid() |
There was a problem hiding this comment.
Currently we receive an "INVALID_TYPE" error when having a null violation. While this is probably technically correct, i think it would be simpler to directly indicate that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup pending from #107