Cleanup Components and IntegrationTest #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohrerF
commented
May 15, 2023
| using Confix.Common.Exceptions; | ||
|
|
||
| namespace Confix.Authoring.GraphQL.Components; | ||
|
|
||
| [ExtendObjectType(OperationTypeNames.Mutation)] | ||
| public sealed class ComponentMutations | ||
| { | ||
| [Error(typeof(SchemaInvalidError))] | ||
| [Error(typeof(ValueSchemaViolation))] | ||
| [Error(typeof(UnauthorizedOperationException))] |
There was a problem hiding this comment.
Why do we not directly use the Exception here instead of wrapping it in an Error Object? @PascalSenn
RohrerF
commented
May 15, 2023
PascalSenn
approved these changes
May 17, 2023
src/Backend/src/Authoring.Abstractions/Components/Models/ComponentScope.cs
Outdated
Show resolved
Hide resolved
| IReadOnlyList<ComponentScope> scopes, | ||
| IDictionary<string, object?>? values, | ||
| JsonElement values, |
There was a problem hiding this comment.
I think a JsonDocument would actually be more correct here right?
src/Backend/src/Authoring.Abstractions/Schema/Exceptions/InvalidSchemaException.cs
Outdated
Show resolved
Hide resolved
src/Backend/test/Authoring.GraphQL.Tests/__snapshots__/SchemaTests.PrintSchema.snap
Show resolved
Hide resolved
src/Backend/test/Authoring.Integration.Tests/AssemblyAttributes.cs
Outdated
Show resolved
Hide resolved
PascalSenn
reviewed
May 17, 2023
src/Backend/src/Authoring.Core/Schema/Services/SchemaValidator.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreatWarningsAsErrorsAnyType->JsonTypeDictionary<string, object?>-> JsonElementComponentStatepart of #106