-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Sampling and suggestion #67
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 52288ff.
A couple updates still need to be made in the UI, specifically, a SQLite icon needs to be added for local development. It should be noted that we do not want to include SQLite for production for security purposes. |
Codecov ReportBase: 66.88% // Head: 71.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 66.88% 71.10% +4.21%
==========================================
Files 67 70 +3
Lines 3053 3267 +214
==========================================
+ Hits 2042 2323 +281
+ Misses 1011 944 -67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
In this PR we are adding support for Sampling and improved expectation suggestions.
Sampling
You are now able to sample data in the following ways for physical tables.
Suggestions
We have moved to using the GE Data Assistant which provides far more suggestions than the Validator implementation.
Additional test coverage has also been added for
app.core.runner
.Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: