-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev -> main #6
Draft
darkbringer1
wants to merge
137
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit of readme file in english
Add shortcuts to sections
Remove: -Framework dependencies Add: -Spm dependencies to the project -Firebase auth initialization # Conflicts: # Project.swift # Resources/GoogleService-Info.plist # Targets/SwiftBuddiesLogin/Sources/LoginView.swift # Targets/SwiftBuddiesMain/Sources/AppMain.swift # Tuist/Package.swift
Remove: -Framework dependencies Add: -Spm dependencies to the project -Firebase auth initialization # Conflicts: # Project.swift # Resources/GoogleService-Info.plist # Targets/SwiftBuddiesMain/Sources/AppMain.swift # Tuist/Package.swift
Change model property
### Issue Link 🔗 <!-- What is your redmine link for this task? --> [Locations Task](#12) ### Goals ⚽ - Map üzerinde etkinlik oluşturmak için Plus (+) butonu eklendi. - Kullanıcı, etkinlik parametrelerini girebileceği bir UI'ye yönlendirildi. - Tüm parametreler girildikten sonra, longPressGesture ile etkinlik konumu seçilebilecek bir UI sağlandı. - Etkinlik oluşturulduktan sonra, MainMapView üzerinde diğer etkinliklerle birlikte görüntülendi. - MainMapView üzerinde etkinlikler arasında smooth animasyonlarla geçiş yapılabilir. - Kırmızı info butonu ile etkinlik detaylarının görüntülendiği bir UI'ye erişim sağlandı. - Etkinlikler, kategorilerine göre filtrelenebilir ve aranan etkinlikler kolayca bulunabilir. ### Implementation Details 🚧 - MVVM Mimarisi kullanıldı. - NetworkManager ile iletişim yine local managerlar üzerinden kurularak istekler atıldı. - LongPressGesture tam verimle çalışması için ikinci map ekranı için RepresentableMapView yazıldı. - Custom anotastonlar ve viewlar kullanmaya özen gösterildi. ### Testing Details 🔍 <!-- Describe what tests you've added for your changes. --> ### Screenshots/Gifs 📷 <div align="center"> <!-- İlk Satır --> <img src="https://github.com/user-attachments/assets/c55444dc-f306-43d3-8baf-7c30541d2588" width="150"> <img src="https://github.com/user-attachments/assets/788169c8-082a-4534-a670-47fcd0297128" width="150"> <img src="https://github.com/user-attachments/assets/6cd40ce7-ac85-42f1-9456-6aa9319e2c81" width="150"> <!-- Boşluk --> <br> <!-- İkinci Satır --> <img src="https://github.com/user-attachments/assets/0a026bc3-527e-4558-9c32-887a81b03ab4" width="150"> <img src="https://github.com/user-attachments/assets/45641b07-eb2e-4165-84db-d6741ed5e005" width="150"> <img src="https://github.com/user-attachments/assets/5da18bef-a5a8-4a0e-9dec-fb1a63b88065" width="150"> </div> ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [x] Other... Please describe:
…ting decode error
### Issue Link 🔗 <!-- What is your redmine link for this task? --> ### Goals ⚽ <!-- List the high-level objectives of this pull request. --> <!-- Include any relevant context. --> ### Implementation Details 🚧 <!-- Explain the reasoning behind any architectural changes. --> <!-- Highlight any new functionality. --> ### Testing Details 🔍 <!-- Describe what tests you've added for your changes. --> ### Screenshots/Gifs 📷 <!-- Add screenshots or Gifs when appropriate. --> How to add gif/screenshots: 1. Drag and drop the gif/screenshot here, let it upload. 2. Copy the link and paste it like below -> ``` <img src="LINK-HERE.gif" width="150"> ``` 3. add the appropriate file extension after it "*.gif" or "*.jpg" - Important: Be careful not to exceed 150 points width that is specified. It makes it harder chech overall ui elements if width is wider than 150 points. Example usage: <img src="https://github.com/SwiftBuddiesTR/BuddiesIOS/assets/40922278/292b39cd-898a-4233-ad6f-137b28351964.gif" width="150"> ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [x] Other... Please describe:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.