[Forge & Fabric 1.20.1] Fix Sweenus/SimplySwords#166

[linstarowo]

The “safeFetch” feature is still retained, but the configuration file is only read once to improve performance

[DrCyanide]

I found a situation where this bug fix would've been really helpful. I've been dual booting Windows and Linux, and my mod pack worlds are on an NTFS drive. Linux has slower read times on NTFS, and the abundance of file read calls has resulted in my FPS dropping to an unplayable 1 FPS (or even 0) with a sword from this modpack on my hotbar.

Spark profiling showed that SimplySwords was more taxing on my system than anything else - including shaders. Just the Config.safeValueFetch() was taking 19.87% of my render thread, compared to 0.47% on Windows. Copying everything over to my Linux EXT4 drive brought it down to 0.16%, but now I've got the problem of needing to copy my game files back and forth if I want to have a usable experience.

(All client side profiling)
Windows profiling: https://spark.lucko.me/2AMJTsOOLB
Linux (NTFS) profiling: https://spark.lucko.me/U1T39JtAqa
Linux (EXT4) profiling: https://spark.lucko.me/wpGSBisQUo

[linstarowo]

I found a situation where this bug fix would've been really helpful. I've been dual booting Windows and Linux, and my mod pack worlds are on an NTFS drive. Linux has slower read times on NTFS, and the abundance of file read calls has resulted in my FPS dropping to an unplayable 1 FPS (or even 0) with a sword from this modpack on my hotbar.

Spark profiling showed that SimplySwords was more taxing on my system than anything else - including shaders. Just the Config.safeValueFetch() was taking 19.87% of my render thread, compared to 0.47% on Windows. Copying everything over to my Linux EXT4 drive brought it down to 0.16%, but now I've got the problem of needing to copy my game files back and forth if I want to have a usable experience.

(All client side profiling) Windows profiling: https://spark.lucko.me/2AMJTsOOLB Linux (NTFS) profiling: https://spark.lucko.me/U1T39JtAqa Linux (EXT4) profiling: https://spark.lucko.me/wpGSBisQUo

Unfortunately, it seems that the developer has abandoned fixing this issue. This is the fixed version I built.
simplyswords-1.56.0-1.20.1-forge.zip
simplyswords-1.56.0-1.20.1-fabric.zip