Handle Integer instead of Fixnum for hash-code computation. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that these are type checked by Typed Racket in 7.5, it's a problem that the documentation doesn't promise that these will be a Fixnum. Switch to using Integer, and change the use of fxxor to match.
|
I think the test failure is because you'd need to merge the similar PR in jsmaniac/typed-struct-props. |
|
Hi, thanks for the fix. I have a bunch of packages that I need to update, so I'm not surprised the tests fail. I'll try to find some time in the coming weeks to update all that stuff… my bad, sorry! |
|
I think just merging this PR will fix the build problem and also fix a number of packages that depend on your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that these are type checked by Typed Racket in 7.5, it's a
problem that the documentation doesn't promise that these will be a
Fixnum. Switch to using Integer, and change the use of fxxor to
match.