Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete existing download of new chapters #1022

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Aug 30, 2024

The downloader checks if pages are already downloaded to prevent unnecessary downloads. However, in case this is e.g. a re-uploaded chapter, this will prevent the new pages from getting downloaded

@schroda schroda force-pushed the fix/automatic_download_of_reuploaded_chapters branch from 336c16f to 6174c1e Compare August 30, 2024 21:27
@Syer10
Copy link
Collaborator

Syer10 commented Aug 31, 2024

I'm not sure about this, what happens with sources that constantly change the chapter URLs?

@schroda
Copy link
Collaborator Author

schroda commented Aug 31, 2024

we could make it a setting which is disabled by default

@Syer10
Copy link
Collaborator

Syer10 commented Aug 31, 2024

I guess that works for now

@schroda
Copy link
Collaborator Author

schroda commented Aug 31, 2024

how common is it that sources change only the url compared to reuploading a chapter?

since it does cause issues where you can end up with different error states

  • mismatch of downloaded pages and page count in database
  • mix of outdated pages and new pages
  • outdated pages

@jobobby04
Copy link

jobobby04 commented Aug 31, 2024

Its very common for a source to change chapter URLs regularly. This has nothing to do with re-uploading a chapter though, this is something some sources have on schedule.

There is no way to tell if it's a re-upload or just a URL change unless the source has specified it. There is only 1 source I know of that actively re-uploads chapters if they find a better version.

The downloader checks if pages are already downloaded to prevent unnecessary downloads.
However, in case this is e.g. a re-uploaded chapter, this will prevent the new pages from getting downloaded
@schroda schroda force-pushed the fix/automatic_download_of_reuploaded_chapters branch from 6174c1e to 6bf7516 Compare September 1, 2024 01:40
This should not have been nullable at all in the first place
@vodkapmp
Copy link

vodkapmp commented Sep 2, 2024

There is only 1 source I know of that actively re-uploads chapters if they find a better version.

My main goto source does this, and if the replaced chapter has more pages than before these pages are appended to the cbz and it ends up making no sense.
(Often happen with first chapters of a volume when replaced with an official release that has 5-6 extra pages at the start, which also means these extras at the start aren't even there just the last 5-6 pages repeated)

I dunno if it's feasible, but maybe the setting could be source specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants