-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete existing download of new chapters #1022
base: master
Are you sure you want to change the base?
Delete existing download of new chapters #1022
Conversation
336c16f
to
6174c1e
Compare
I'm not sure about this, what happens with sources that constantly change the chapter URLs? |
we could make it a setting which is disabled by default |
I guess that works for now |
how common is it that sources change only the url compared to reuploading a chapter? since it does cause issues where you can end up with different error states
|
Its very common for a source to change chapter URLs regularly. This has nothing to do with re-uploading a chapter though, this is something some sources have on schedule. There is no way to tell if it's a re-upload or just a URL change unless the source has specified it. There is only 1 source I know of that actively re-uploads chapters if they find a better version. |
The downloader checks if pages are already downloaded to prevent unnecessary downloads. However, in case this is e.g. a re-uploaded chapter, this will prevent the new pages from getting downloaded
6174c1e
to
6bf7516
Compare
This should not have been nullable at all in the first place
My main goto source does this, and if the replaced chapter has more pages than before these pages are appended to the cbz and it ends up making no sense. I dunno if it's feasible, but maybe the setting could be source specific? |
The downloader checks if pages are already downloaded to prevent unnecessary downloads. However, in case this is e.g. a re-uploaded chapter, this will prevent the new pages from getting downloaded