Skip to content

Conversation

@yagizmunger
Copy link

@michaelblyons
Copy link
Contributor

Please add some regression tests.

@yagizmunger
Copy link
Author

Please add some regression tests.

Added here. If further tests are needed, could you point to relevant documentation if there are any?

@michaelblyons
Copy link
Contributor

michaelblyons commented Nov 6, 2025

You have the right idea, but it looks like your columns aren't lined up quite right. I recommend the PackageDev package for writing tests.1 Just click at the end of the line to be tested and Ctrl+Enter to automatically generate all the positive test assertions that can be made with ^s.

If negative assertions are needed, you have to write those yourself, but PackageDev will highlight the characters being tested if you click on a test line.

Footnotes

  1. Also for editing syntax definitions and lots of other Sublime-specific files.

@yagizmunger
Copy link
Author

Modified tests to be generated with PackageDev, which seems to be a helpful tool.

One thing to note is that the tests would only run if they're located under Packages directory. Is there any other way to run the tests without relocating them?

@michaelblyons
Copy link
Contributor

One thing to note is that the tests would only run if they're located under Packages directory. Is there any other way to run the tests without relocating them?

I don't think so. Most of the time people who are working on syntax packages seem to have them cloned or symlinked to Packages. See for example the ReadMe for contributing to the packages shipped with ST.

I could be wrong, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template literals are not escaped on interpolated strings

2 participants