Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds smoke tests #5

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adds smoke tests #5

wants to merge 6 commits into from

Conversation

ViMaSter
Copy link
Member

@ViMaSter ViMaSter commented Nov 3, 2023

Summary

Wanted to add automated version updates, but realized we don't have any way to make sure the website still works after we upgrade packages.
We currently do deploy it to preview.studio-lovelies.com for each PR, but it might just not respond or return a 404; GitHub wouldn't care and declare the deployment completed successfully.

This PR adds test that ensure that the home page / works and /404 actually returns a 404.
Consider this a smoke test for the web server.

Also updates the README to contain everything previously only established via chat.

Testing instructions

  1. Make sure what the README says actually works
  2. Check that preview.studio-lovelies.com still looks fine

Additional information

  • [ ] Changes UI
  • [ ] Has associated resource:

@ViMaSter ViMaSter enabled auto-merge (rebase) November 3, 2023 03:01
@ViMaSter
Copy link
Member Author

ViMaSter commented Nov 9, 2023

Snuck in two performance improvements that cause the Largest Contentful Paint (LCP) to occur earlier:

  • 61973cf: fonts are now pre-loaded
  • 3d00bcd: resized the logo images to x2 of their largest rendered size (90px in height); the original files still exist tho

Page should feel a bit snappier now. 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant