Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seductive reasoning parser basics #362

Closed
wants to merge 5 commits into from

Conversation

ViMaSter
Copy link
Member

@ViMaSter ViMaSter commented Jul 2, 2023

DRAFT PR UNTIL NO LONGER WIP

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Attention: Patch coverage is 85.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.33%. Comparing base (cdacdc2) to head (6cf25c7).
Report is 178 commits behind head on develop.

Files with missing lines Patch % Lines
...s/Scripts/TextDecoder/Parser/PhraseFormatParser.cs 79.54% 9 Missing ⚠️
...ty-ggjj/Assets/Scripts/TextDecoder/PhraseFormat.cs 87.50% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cdacdc2) and HEAD (6cf25c7). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (cdacdc2) HEAD (6cf25c7)
5 2
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #362       +/-   ##
============================================
- Coverage    78.48%   28.33%   -50.16%     
============================================
  Files           83       85        +2     
  Lines         2980     3060       +80     
============================================
- Hits          2339      867     -1472     
- Misses         641     2193     +1552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViMaSter ViMaSter force-pushed the features/vimaster/seductive-reasoning branch from 35eb5d9 to 6cf25c7 Compare July 8, 2023 23:20
@ViMaSter ViMaSter closed this Aug 31, 2024
@ViMaSter ViMaSter deleted the features/vimaster/seductive-reasoning branch August 31, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants