-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No-op code & docs cleanups #245
Open
alyst
wants to merge
12
commits into
StructuralEquationModels:devel
Choose a base branch
from
alyst:noop_cleanups
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove unused _symbolic fields
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #245 +/- ##
==========================================
- Coverage 72.94% 72.82% -0.13%
==========================================
Files 50 50
Lines 2218 2208 -10
==========================================
- Hits 1618 1608 -10
Misses 600 600 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are rather trivial commits cherry-picked from #193 that don't change anything essential, but once they are in, it should be easier to manage the rest.
The changes are:
using
directives from the individual unit test .jl files to the parent .jl fileRAMSymbolic
renamexxx_function
toxxx_eval!
as that better follows Julia naming conventions and should make the code a bit more readable (and shorter)This is a bit less trivial set of changes than the rest, but in the end it does not really change how the functions are calculated.
Except for switching p-values calculation to use
ccdf(x)
instead of1 - cdf(x)
-- this could potentially give more precise results for p-values close to 0.