Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. fixes #196

Merged
merged 23 commits into from
Apr 20, 2024
+162 −171
Merged

Misc. fixes #196

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
893c959
const SEM=StructuralEquationModels
Mar 16, 2024
18e57fa
obj_grad_hess: simplify mapreduce
Mar 9, 2024
5780be0
cov_and_mean(): use StatsBase.mean_and_cov()
alyst Apr 20, 2024
dae0d83
==: use &&
Mar 9, 2024
ec5310a
use Fix1 instead of anonymous function
Mar 9, 2024
47ce5a6
fix typo
Mar 9, 2024
dabb3f9
rename vars for type stability
Mar 9, 2024
38349d8
reorder_data(): optimize
Mar 10, 2024
4236bd5
SemObservedData(): cleanup code
Mar 10, 2024
d3b7326
fix typo
Mar 12, 2024
f9fcef0
tiny simplification
alyst Mar 20, 2024
8f88704
fix typo
Apr 3, 2024
87ff250
reorder_obs_cov/mean(): cleanup
Mar 12, 2024
af939be
remove no-op method
Mar 17, 2024
2803b55
remove module spec
Mar 16, 2024
caf35e2
RAMMatrices: cleanup indexing params in arrays
alyst Apr 20, 2024
29f7f5b
fill_A_S_M(): use `@inbounds`
Mar 9, 2024
ef25f8c
fill_A_S_M!(): add !, specify argtypes
Mar 10, 2024
4794301
fix dangling whitespace
alyst Apr 20, 2024
e084533
remove spurious "using SEM"
Mar 11, 2024
b901d97
tests/examples: import -> using
alyst Apr 20, 2024
a37a9a7
test: use proper partable
Mar 20, 2024
47ae507
tests: turn JuliaFormatter check to warn
alyst Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove no-op method
@alyst
Alexey Stukalov authored and alyst committed Apr 20, 2024
commit af939be11478c758afd5b73b2b0709e527e83caf
4 changes: 2 additions & 2 deletions src/observed/covariance.jl
View file
Original file line number Diff line number Diff line change
@@ -76,7 +76,8 @@ function SemObservedCovariance(;

if !isnothing(spec_colnames)
obs_cov = reorder_obs_cov(obs_cov, spec_colnames, obs_colnames)
obs_mean = reorder_obs_mean(obs_mean, spec_colnames, obs_colnames)
isnothing(obs_mean) ||
(obs_mean = reorder_obs_mean(obs_mean, spec_colnames, obs_colnames))
end

n_man = Float64(size(obs_cov, 1))
@@ -114,7 +115,6 @@ function reorder_obs_cov(obs_cov, spec_colnames, obs_colnames)
end

# reorder means ----------------------------------------------------------------------------
reorder_obs_mean(obs_mean::Nothing, spec_colnames, obs_colnames) = nothing

function reorder_obs_mean(obs_mean, spec_colnames, obs_colnames)
if spec_colnames == obs_colnames