-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved here the pylint tools of abacus. #4
base: master
Are you sure you want to change the base?
Conversation
I also changed abacus' rc file a bit: disabled bare-except and broad-except.
shutil.rmtree(tempDir) | ||
|
||
parser = argparse.ArgumentParser(description='pylint zipped files or single python files') | ||
parser.add_argument('--zip', dest="zipfiles", default=[], action='append', help='zip file with source:relative package path to verify inside zip file (e.g. strato)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace --zip --file and --dir with automatic detection of type (name.endswith('.zip') and os.isdir())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you add nargs='*' you can type
--files a.py b.py c.py
or
--files *.py
instead of
--file a.py --file b.py --file c.py
IMHO bare-except and broad-except should not be excluded - they are bad practice. If you really want them, take the trouble to type pylint: disable= |
@lior-stratoscale, I think that bare/broad excepts are okay: 1. people that write them know what they do; 2. I wonder how often there is really a specific case to handle, vs the common "log and raise" or "just don't die" cases. About the other changes, when time permits... |
and another thing: why is this in its own repo? |
strato-pylint already exists, and promoted by Pavel. |
I also changed abacus' rc file a bit: disable bare-except and broad-except.