Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Combination of unevaluatedProperties with allOf and oneOf #509

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Stranger6667
Copy link
Owner

Fixes #496

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (3c58526) to head (16549a7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../jsonschema/src/keywords/unevaluated_properties.rs 92.30% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   84.66%   84.70%   +0.04%     
==========================================
  Files          69       69              
  Lines       10910    10939      +29     
==========================================
+ Hits         9237     9266      +29     
  Misses       1673     1673              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #509 will degrade performances by 13.61%

Comparing dd/fix-unevaluated (16549a7) with master (3c58526)

Summary

❌ 1 (👁 1) regressions
✅ 16 untouched benchmarks

Benchmarks breakdown

Benchmark master dd/fix-unevaluated Change
👁 Fast/Invalid[is_valid] 740.3 ns 856.9 ns -13.61%

@Stranger6667 Stranger6667 merged commit 7ef1155 into master Sep 13, 2024
28 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-unevaluated branch September 13, 2024 20:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect/inconsistent validation result when combining unevaluatedProperties/allOf/oneOf
1 participant