Update the Tests #2066
Merged
Update the Tests #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
🚀 Translation Verification Summary📋 Checking with the file
|
github-actions
bot
removed
Documentation
|
@Frooodle could you please have a look at this! |
Frooodle
approved these changes
Oct 24, 2024
chottuthejimmy
added a commit
to testdriverai/Stirling-PDF
that referenced
this pull request
Nov 15, 2024
* use transform instead of change * disable workflows * updates expect commands as well * try "highlighted" * update versions * update workflow files * Remove pro badge if enabled * add some wait time --------- Co-authored-by: Anthony Stirling <[email protected]> Co-authored-by: a <a>
Frooodle
added a commit
that referenced
this pull request
Nov 15, 2024
* use transform instead of change * disable workflows * updates expect commands as well * try "highlighted" * update versions * update workflow files * Remove pro badge if enabled * add some wait time * Fix metricCollection * Update PostHogService.java * Update messages_de_DE.properties (#2070) * Update messages_de_DE.properties Completed translations for German language. * Update messages_de_DE.properties * Update messages_it_IT.properties (#2077) * extract and apply the image orientation from exif data in imageToPdf (#2073) * Update 3rd Party Licenses (#2080) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> * visual certificate signing (#2084) add visual digital signature * added some missing translations (#2085) * Auto detect presence of external dependencies (LibreOffice etc) and disable/enable features dynamically (#2082) * Create ExternalAppDepConfig.java * Update EndpointConfiguration.java * Hardening suggestions for Stirling-PDF / ExternalAppDepConfig (#2083) Switch order of literals to prevent NullPointerException Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> --------- Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> * 📝 Update README: Translation Progress Table (#2072) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Spanish translate (#2102) * Spanish translate * Added blank line --------- Co-authored-by: Manu <[email protected]> * Optimierung der SAML2-Integration und Verbesserung der Zertifikats- und Fehlerbehandlung (#2105) * certificate processing * Hides dialog when provider list is empty * removed: unused * Modernize and secure temp file creation (#2106) Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> * Bump springBootVersion from 3.3.4 to 3.3.5 (#2117) Bumps `springBootVersion` from 3.3.4 to 3.3.5. Updates `org.springframework.boot:spring-boot-starter-web` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-jetty` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-thymeleaf` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-security` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-data-jpa` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-oauth2-client` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-test` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-starter-actuator` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) Updates `org.springframework.boot:spring-boot-devtools` from 3.3.4 to 3.3.5 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-web dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-jetty dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-thymeleaf dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-security dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-data-jpa dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-oauth2-client dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-test dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-actuator dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-devtools dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.springframework.boot from 3.3.4 to 3.3.5 (#2118) Bumps [org.springframework.boot](https://github.com/spring-projects/spring-boot) from 3.3.4 to 3.3.5. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.4...v3.3.5) --- updated-dependencies: - dependency-name: org.springframework.boot dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 📝 Update README: Translation Progress Table (#2103) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update 3rd Party Licenses (#2119) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> * Add new french translations (#2120) Add new french translations and improve simple quote * Feature/298 improve compare performance (#2124) * Implement Diff.js * Compare feature - add service worker and improve efficiency for large files * Compare - messages updated to be compatable with language packs * Compare - Acknowledge Diff.js usage * Add message warning there is no text in uploaded pdf to messages file --------- Co-authored-by: Anthony Stirling <[email protected]> * Update translation files (#2125) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> * 📝 Update README: Translation Progress Table (#2121) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix csrf (#2126) * apply fix * Fixes empty th:action * Update build.gradle * fix * formatting --------- Co-authored-by: Dimitrios Kaitantzidis <[email protected]> * Update id_ID Translation and fix some grammars (#2108) * Update id_ID Translation and fix some grammars * sync lines to fix build warning * get back new line at end of file --------- Co-authored-by: Anthony Stirling <[email protected]> * 📝 Update README: Translation Progress Table (#2129) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Feature/save signs (#2127) * apply fix * Fixes empty th:action * Update build.gradle * fix * formatting * Save signatures * Fix code scanning alert no. 42: Uncontrolled data used in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix UserServiceInterface * Merge branch 'feature/saveSigns' of [email protected]:Stirling-Tools/Stirling-PDF.git into feature/saveSigns * 0.31.0 bump and further csrf * formatting * preview name * add * sign doc * Update translation files (#2128) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> --------- Signed-off-by: GitHub Action <[email protected]> Co-authored-by: Dimitrios Kaitantzidis <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: a <a> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> * 📝 Update README: Translation Progress Table (#2133) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * :floppy_disk: Update Version (#2132) :floppy_disk: Sync Versions > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Bump org.springframework.security:spring-security-saml2-service-provider from 6.3.3 to 6.3.4 (#2052) Bump org.springframework.security:spring-security-saml2-service-provider Bumps [org.springframework.security:spring-security-saml2-service-provider](https://github.com/spring-projects/spring-security) from 6.3.3 to 6.3.4. - [Release notes](https://github.com/spring-projects/spring-security/releases) - [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc) - [Commits](spring-projects/spring-security@6.3.3...6.3.4) --- updated-dependencies: - dependency-name: org.springframework.security:spring-security-saml2-service-provider dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update 3rd Party Licenses (#2134) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> * chore(helm): bump chart version according to semver (#2109) Signed-off-by: Ludovic Ortega <[email protected]> * Update messages_it_IT.properties (#2135) * [bug fix] Update compress-pdf.html (#2138) Update compress-pdf.html * Update build.gradle * 💾 Update Version (#2139) :floppy_disk: Sync Versions > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update README.md * navbar.css: prevent overlapping of elements (#2140) go-pro-link is overlapping the settings button * Update pull_request_template.md * fix signature logo not loading and add option to disable it (#2143) * fix signature logo not loading and add option to disable it * Hardening suggestions for Stirling-PDF / fix-sig-logo (#2144) Modernize and secure temp file creation Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> --------- Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> * Update translation files (#2145) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> * 📝 Update README: Translation Progress Table (#2136) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update messages_it_IT.properties (#2146) * fixed minor bugs in Markdown (#2152) * re-config labeler & add new labels (#2153) Co-authored-by: Anthony Stirling <[email protected]> * Fix: redeclaration of const and add: tranlation placeholder for Session Expiry Messages (#2158) Fix: redeclaration of const * Fix: Path correction to draggable.js #2154 + little makeup (#2159) * Fix: Add missing .map file for minified files (#2156) * Update messages_it_IT.properties (#2161) * Fix: Auto language detection #2122 (#2148) * Fix: Auto language detection #2122 * add LanguageService and AdditionalLanguageJsController * hidden swagger * 📝 Update README: Translation Progress Table (#2160) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Completed translations for 19 languages using AI (#2164) Created translations for various languages using AI * Corrects AI generated translation (#2166) * Fix: Navbar layout overflow (#2162) Fix: Navbar layout overflow using Bootstrap class .navbar-expand-xl Co-authored-by: Harshad Marathe <harshad@DESKTOP-1MNKUHA> * 📝 Update README: Translation Progress Table (#2165) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: add helm chart github action (#2113) * feat: add helm chart github action Signed-off-by: Ludovic Ortega <[email protected]> * fix: remove test branch Signed-off-by: Ludovic Ortega <[email protected]> * fix: run helm-docs-built after syncing version Signed-off-by: Ludovic Ortega <[email protected]> * fix: helm repo url --------- Signed-off-by: Ludovic Ortega <[email protected]> * fix remmeber me (#2184) * fix remmeber me * remove uselss comment * Update translation files (#2185) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> --------- Signed-off-by: GitHub Action <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> * Added input sanitization to fix self-xss issue (#2189) * Update and improve zh_TW Traditional Chinese locale (#2188) * 📝 Update README: Translation Progress Table (#2190) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [Feature] Set Executor Instances limits dynamically from properties (#2193) * Update 'ProcessExecutor.java' to use dynamic process limits from properties * Move limits location out of 'application.properties' * Rename 'SemaphoreLimit' to 'SessionLimit' and bundle with 'Timeout...' into one parent class * Searchbar in nav auto select, and exe nolonger disable CLI (#2197) * fix remmeber me * remove uselss comment * Update translation files (#2185) Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> * exe no longer disable CLI --------- Signed-off-by: GitHub Action <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: a <a> * Add option to insert blank page between pages in Multi-tool (#2194) (#2201) * Fix: Card has no favorite icon (#2203) fixes the bug if the card has no favorite icon * Rename lint-helm-charts.yml to lint-helm-charts.yml-disabled * Rename release-helm-charts.yml to release-helm-charts.yml-disabled * Update build.gradle * 💾 Update Version (#2204) :floppy_disk: Sync Versions > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update build.gradle * :floppy_disk: Update Version (#2205) :floppy_disk: Sync Versions > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: missing opener for View PDF #2206 (#2207) Fix missing opener for View PDF #2206 * feat: move helm chart to https://github.com/Stirling-Tools/Stirling-PDF-chart (#2208) * feat: remove helm chart Signed-off-by: Ludovic Ortega <[email protected]> * feat: mention kubernetes in install doc Signed-off-by: Ludovic Ortega <[email protected]> --------- Signed-off-by: Ludovic Ortega <[email protected]> * Update Version-groups.md * Fix: Reading the username based on the login method. (#2211) * Update messages_ca_CA.properties (#2210) * Update messages_ca_CA.properties Partial Catalan Translation Contribution for Stirling PDF Hi, I’ve completed a partial Catalan translation for Stirling PDF, covering all strings up to the Pipeline section. I focused on maintaining consistency in terminology to ensure a smooth user experience in Catalan. * Update messages_ca_CA.properties Update on Catalan Translation Verification – Test 2 Passed Hi [Developer’s Name], I’ve now completed the verification for Test 2 and ensured that all keys in messages_en_GB.properties align with those in messages_ca_CA.properties. The files should now be fully synchronized with no missing or extra keys. I’ll proceed to re-run the tests to confirm everything is in order. Please feel free to review the updated pull request, and let me know if there’s anything further you’d like me to adjust. Thank you for your support! Best regards, --------- Co-authored-by: Anthony Stirling <[email protected]> * Update get-info-on-pdf.html #2212 * 📝 Update README: Translation Progress Table (#2214) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update README.md * Update HowToUseOCR.md * Restricting file input to .md files for Markdown to PDF conversion (#2219) Co-authored-by: Harshad Marathe <harshad@DESKTOP-1MNKUHA> * Removes references to nonexistent endpoint (#2223) * Catalan Translation - Stirling PDF String Updates (#2222) * Update messages_ca_CA.properties Partial Catalan Translation Contribution for Stirling PDF Hi, I’ve completed a partial Catalan translation for Stirling PDF, covering all strings up to the Pipeline section. I focused on maintaining consistency in terminology to ensure a smooth user experience in Catalan. * Update messages_ca_CA.properties Update on Catalan Translation Verification – Test 2 Passed Hi [Developer’s Name], I’ve now completed the verification for Test 2 and ensured that all keys in messages_en_GB.properties align with those in messages_ca_CA.properties. The files should now be fully synchronized with no missing or extra keys. I’ll proceed to re-run the tests to confirm everything is in order. Please feel free to review the updated pull request, and let me know if there’s anything further you’d like me to adjust. Thank you for your support! Best regards, * Catalan Translation - Stirling PDF String Updates Hi, I have worked on the Catalan translation for some of the text strings in the Stirling PDF project. Attached are my contributions, which include the relevant strings for various parts of the system. I’ve made a few small adjustments to ensure the translation is as accurate and coherent as possible in technical contexts. Changes made: 1. Translation of strings related to PDF manipulation tools (e.g., Add Watermark, Split PDF, etc.). 2. Adjustments of terms for better accuracy, such as using “Eliminar” instead of “Treure” or “Esborrar”. 3. Review of technical translations to ensure consistency, such as using “Nombre” instead of “Quantitat” for referring to the number of documents or pages. Attached are the modified strings for your review: • [Attach the modified strings file] If you have any questions or need further adjustments, I’m happy to help. Thank you for your attention and for all your work on the project! Best regards, * Catalan Translation - Stirling PDF String Updates Hi, I have worked on the Catalan translation for some of the text strings in the Stirling PDF project. Attached are my contributions, which include the relevant strings for various parts of the system. I’ve made a few small adjustments to ensure the translation is as accurate and coherent as possible in technical contexts. Changes made: 1. Translation of strings related to PDF manipulation tools (e.g., Add Watermark, Split PDF, etc.). 2. Adjustments of terms for better accuracy, such as using “Eliminar” instead of “Treure” or “Esborrar”. 3. Review of technical translations to ensure consistency, such as using “Nombre” instead of “Quantitat” for referring to the number of documents or pages. Attached are the modified strings for your review: • [Attach the modified strings file] If you have any questions or need further adjustments, I’m happy to help. Thank you for your attention and for all your work on the project! Best regards, * Catalan Translation - Stirling PDF String Updates Hi, I have worked on the Catalan translation for some of the text strings in the Stirling PDF project. Attached are my contributions, which include the relevant strings for various parts of the system. I’ve made a few small adjustments to ensure the translation is as accurate and coherent as possible in technical contexts. Changes made: 1. Translation of strings related to PDF manipulation tools (e.g., Add Watermark, Split PDF, etc.). 2. Adjustments of terms for better accuracy, such as using “Eliminar” instead of “Treure” or “Esborrar”. 3. Review of technical translations to ensure consistency, such as using “Nombre” instead of “Quantitat” for referring to the number of documents or pages. Attached are the modified strings for your review: • [Attach the modified strings file] If you have any questions or need further adjustments, I’m happy to help. Thank you for your attention and for all your work on the project! Best regards, * Catalan Translation - Stirling PDF String Updates * 📝 Sync README > Made via sync_files.yml --------- Co-authored-by: Anthony Stirling <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * adds missing dependencies in the endpoints (#2224) * Mention HTTP error 413 in FAQ (#2226) * Fix canvas crop (#2221) * WIP: fixes canvas and rect to crop - small problem in smaller screens - neew to fix re render page on resize * Closes #2209 * Increase watermark coverage to fill page (#2049) (#2220) * Increase watermark coverage to fill page (#2049) * Increase watermark coverage to fill page with the new calculation (#2049) * Update pull_request_template.md * Setup new docker org stirlingtools/stirling-pdf (#2232) * Update push-docker.yml * Update push-docker.yml * Update push-docker.yml * Feature/1976/multi tool multiple pages (#2200) * Multitool - Select multiple pages for rotation tool * Multitool multi select delete feature * Multitool multi select UI improvements and big fixes * Multitool multi select select all and UI improvements * Multi tool multi select, download selected, clean up and bug fixes * Comments * Update buttons for page selection * Update translation files Signed-off-by: GitHub Action <[email protected]> * Multitool multiselect split functionality and UI updates * Download selected button, additional tooltips * Update translation files Signed-off-by: GitHub Action <[email protected]> * revert CertSignController * remove material icons * restore to previous certsigncontroller * Update CertSignController.java --------- Signed-off-by: GitHub Action <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Anthony Stirling <[email protected]> * 📝 Update README: Translation Progress Table (#2236) :memo: Sync README > Made via sync_files.yml Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: Ensure backend receives false when checkbox is unchecked in split-pdf-by-chapters feature (#2234) * Implemented hidden input tags to resolve issue with file input handling * Cleanup: Remove log statements for production readiness --------- Co-authored-by: Harshad Marathe <harshad@DESKTOP-1MNKUHA> Co-authored-by: Anthony Stirling <[email protected]> * Update the Tests (#2066) * use transform instead of change * disable workflows * updates expect commands as well * try "highlighted" * update versions * update workflow files * Remove pro badge if enabled * add some wait time --------- Co-authored-by: Anthony Stirling <[email protected]> Co-authored-by: a <a> * try this --------- Signed-off-by: GitHub Action <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ludovic Ortega <[email protected]> Co-authored-by: Anthony Stirling <[email protected]> Co-authored-by: a <a> Co-authored-by: Corbinian Grimm <[email protected]> Co-authored-by: albanobattistella <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: swanemar <[email protected]> Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Manuel Mora Gordillo <[email protected]> Co-authored-by: Manu <[email protected]> Co-authored-by: Ludy <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Florian Fish <[email protected]> Co-authored-by: reecebrowne <[email protected]> Co-authored-by: Dimitrios Kaitantzidis <[email protected]> Co-authored-by: Rania Amina <[email protected]> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Ludovic Ortega <[email protected]> Co-authored-by: Philip H. <[email protected]> Co-authored-by: Saud Fatayerji <[email protected]> Co-authored-by: MaratheHarshad <[email protected]> Co-authored-by: Harshad Marathe <harshad@DESKTOP-1MNKUHA> Co-authored-by: ninjat <[email protected]> Co-authored-by: Peter Dave Hello <[email protected]> Co-authored-by: Rafael Encinas <[email protected]> Co-authored-by: Renan <[email protected]> Co-authored-by: leo-jmateo <[email protected]> Co-authored-by: S. Neuhaus <[email protected]> Co-authored-by: Dimitris Kaitantzidis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Anthony, hope you are doing well mate.
Following up with the tests from #1957 , well looked into the issues and we worked hard to get everything fixed.
So one of the issues which should be noted was we had keywords like "changed" but the AI doesn't really know what's changed or what it looked before the change occurred, which is basically because we take screenshots and we do really embed them together.
So if you / anyone who's going to be writing further more tests should be aware of this (I will prob write some prompt engg docs, which I will link here when its done)
So previously the prompt was :
And I changed it to this :
I also saw that you have a draft PR #2005 on this, so I have just set the base to testdriver branch.
Cheers! 🤠